Skip to content

chore(ci): add workflow for unused dependencies #1430

Closed
DoTheBestToGetTheBest wants to merge 2 commits intoethereum:masterfrom
DoTheBestToGetTheBest:add-deps-check
Closed

chore(ci): add workflow for unused dependencies #1430
DoTheBestToGetTheBest wants to merge 2 commits intoethereum:masterfrom
DoTheBestToGetTheBest:add-deps-check

Conversation

@DoTheBestToGetTheBest
Copy link
Copy Markdown

should closes #1418

@DoTheBestToGetTheBest DoTheBestToGetTheBest changed the title feat: add workflow for unused dependencies chore(ci): add workflow for unused dependencies Sep 8, 2024
@KolbyML KolbyML requested a review from carver September 8, 2024 21:12
@KolbyML
Copy link
Copy Markdown
Member

KolbyML commented Oct 3, 2024

@DoTheBestToGetTheBest sorry for the delay I will take over reviewing this PR.

Could you make udeps run on every PR like this example https://github.com/paradigmxyz/reth/blob/ab069979867087b72c1dfe24b535cd997b3b5f4b/.github/workflows/lint.yml#L133-L144

I know the original issue said make it once a week, but I think it makes sense to run it on every run like we do with our CI / commitlint CI

@KolbyML
Copy link
Copy Markdown
Member

KolbyML commented Feb 22, 2025

Closing as there has been no response since October

@KolbyML KolbyML closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have a regular cargo-udeps check

2 participants